Skip to content

Conversation

bwees
Copy link
Member

@bwees bwees commented Aug 6, 2025

Description

Adds album activities to shared album.

Current Problems:

  • Unfavoriting does not work

Fixes #20206

How Has This Been Tested?

Tested with remote album on owner view and shared user view

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@bwees bwees force-pushed the feat/shared-album-interactions branch from 626f120 to d661081 Compare August 11, 2025 19:23
@bwees bwees force-pushed the feat/shared-album-interactions branch from d661081 to 41df97f Compare August 12, 2025 16:57
@bwees bwees marked this pull request as ready for review August 12, 2025 19:35
bwees and others added 3 commits August 13, 2025 17:20
* fix(mobile): newest/oldest album sort

* chore: use sqlite to determine album asset timestamps

* Fix missing future

Co-authored-by: Alex <[email protected]>

* fix: async handling of sort

* chore: tests

* chore: code review changes

* fix: use created at for newest asset

* fix: use localDateTime for sorting

* chore: cleanup

* chore: use final

* feat: loading indicator

---------

Co-authored-by: Alex <[email protected]>
@bwees bwees requested a review from alextran1502 August 14, 2025 22:38
@alextran1502 alextran1502 enabled auto-merge (squash) August 14, 2025 22:50
@alextran1502 alextran1502 merged commit 1926c90 into main Aug 14, 2025
58 checks passed
@alextran1502 alextran1502 deleted the feat/shared-album-interactions branch August 14, 2025 22:50
ollioddi pushed a commit to ollioddi/immich that referenced this pull request Aug 27, 2025
* feat(mobile): shared album activities

* add like buttons and fix behavior of unliking

* fix: conditionally show activity button and fix title truncations

* fix(mobile): newest/oldest album sort (immich-app#20743)

* fix(mobile): newest/oldest album sort

* chore: use sqlite to determine album asset timestamps

* Fix missing future

Co-authored-by: Alex <[email protected]>

* fix: async handling of sort

* chore: tests

* chore: code review changes

* fix: use created at for newest asset

* fix: use localDateTime for sorting

* chore: cleanup

* chore: use final

* feat: loading indicator

---------

Co-authored-by: Alex <[email protected]>

---------

Co-authored-by: Alex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[beta] no ability to like and comment in shared albums
2 participants