fix(web): prevent thumbhashes from covering search bar #20720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploying preview environment to https://pr-20720.preview.internal.immich.cloud/ |
uhthomas
commented
Aug 6, 2025
| {#if (!loaded || thumbError) && asset.thumbhash} | ||
| <canvas | ||
| use:thumbhash={{ base64ThumbHash: asset.thumbhash }} | ||
| class="absolute object-cover" |
There was a problem hiding this comment.
also note the z index class has been removed
|
I'm going to find out why we define the thumbhash in two places and which is the right one to use, and whether it breaks displaying errors. |
|
So from testing quickly, it's not making anything worse. It looks like thumbhashes already hide the error state. I'll try and clean it up though as I'm here. |
uhthomas
force-pushed
the
fix-web-thumbhash-z-index
branch
4 times, most recently
from
440fffd to
3f42693
Compare
The thumbhash had a z-index setting which meant it would cover the search bar, and would always cause weird animations when scrolling up in search results. This is fixable by removing the z-index and moving it in front the other elements to get a naturally higher higher z-index preference.
uhthomas
force-pushed
the
fix-web-thumbhash-z-index
branch
from
3f42693 to
d1dc321
Compare
uhthomas
requested review from
alextran1502,
zackpollard,
danieldietzler and
mertalev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The thumbhash had a z-index setting which meant it would cover the search bar, and would always cause weird animations when scrolling up in search results.
This is fixable by removing the z-index and moving it in front the other elements to get a naturally higher higher z-index preference.
How Has This Been Tested?
I've tested locally, but I can also test on the preview instance too.
Screenshots (if appropriate)
Before:
After:
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)