fix(web): limit max height of search results #20727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The height of the search results element was unrestricted, which meant that the asset visibility calculations were completely incorrect. The consequence of this is that assets which should not have been visible, were. In practical terms, all assets below the viewport were rendered when they shouldn't have been which is terrible for performance. Limiting the height of the viewport fixes that calculation and assets are correctly hidden. The consequence of limiting the height of the viewport is that the intersector then incorrectly thought the scroll position was always at the end. This has been fixed by calculating the position of sliding window against the calculated asset layout container height.
|
Deploying preview environment to https://pr-20727.preview.internal.immich.cloud/ |
uhthomas
requested review from
zackpollard,
midzelis,
alextran1502,
danieldietzler and
mertalev
danieldietzler
approved these changes
Aug 6, 2025
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 11, 2025
The height of the search results element was unrestricted, which meant that the asset visibility calculations were completely incorrect. The consequence of this is that assets which should not have been visible, were. In practical terms, all assets below the viewport were rendered when they shouldn't have been which is terrible for performance. Limiting the height of the viewport fixes that calculation and assets are correctly hidden. The consequence of limiting the height of the viewport is that the intersector then incorrectly thought the scroll position was always at the end. This has been fixed by calculating the position of sliding window against the calculated asset layout container height. Co-authored-by: Alex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The height of the search results element was unrestricted, which meant that the asset visibility calculations were completely incorrect. The consequence of this is that assets which should not have been visible, were. In practical terms, all assets below the viewport were rendered when they shouldn't have been which is terrible for performance. Limiting the height of the viewport fixes that calculation and assets are correctly hidden.
The consequence of limiting the height of the viewport is that the intersector then incorrectly thought the scroll position was always at the end. This has been fixed by calculating the position of sliding window against the calculated asset layout container height.
How Has This Been Tested?
Tested locally.
Screenshots (if appropriate)
Before:
After:
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)