feat: handle SyncResetV1 #20732
Merged
feat: handle SyncResetV1 #20732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only thing I would say here is that in this case it would be ideal to immediately queue a new sync after this one completes, not sure what the semantics of that would look like though. |
I can think of few ways to do this but none of them are as elegant as having something like the Job queue on the server ':) |
| // https://www.sqlite.org/pragma.html#pragma_foreign_keys | ||
| await _db.customStatement('PRAGMA foreign_keys = OFF'); | ||
| await transaction(() async { | ||
| await _db.assetFaceEntity.deleteAll(); |
There was a problem hiding this comment.
Is this the correct call for the table's order?
There was a problem hiding this comment.
The deletes won't fail as we disable the foreign key constraints before calling the delete method on the entities
shenlong-tanwen
force-pushed
the
feat/handle-syncresetv1
branch
from
7a4f67f to
056b4e8
Compare
shenlong-tanwen
force-pushed
the
feat/handle-syncresetv1
branch
from
056b4e8 to
8f5f1c7
Compare
zackpollard
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How was this tested