fix(web): fix layout loop with single row grids in explore page #20833
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20829.
SingleGridRow
doesn't actually enforce through grid styles that the grid should be laid out in a single row.This makes Firefox get stuck in an infinite layout loop in the Explore page:
itemCount
N that Firefox lays out in two rows.itemCount
, now N-1, which Firefox lays out in a single row.This patch stops the People and Places grids from being laid out in two rows using
grid-flow-col
.SingleGridRow is also used in SearchPeopleSection but I haven't been able to reproduce a similar layout loop there.
How Has This Been Tested?
Checklist:
src/services/
uses repositories implementations for database calls, filesystem operations, etc.src/repositories/
is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/
)