-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: Shared Links: Slug Support, UI Refactor, and Simplified Actions #24856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rity and usability
|
@Lauritz-Tieste Can you split this PR into multiple independent PRs so it'll be easier to get the simpler ones in? For instance, the slug support can go on it's own without the UI refactor |
I would try to split the two changes (slug support and new UI) into multiple PRs, but unfortunately I don't have the time for that at the moment. |
Description
This pull request introduces support for a new
slugfield in theSharedLinkmodel and refactors the shared link UI for improved usability and maintainability. The changes ensure that slugs are handled throughout the model, service, and UI layers, and update the shared link list and item presentation for a more modern and user-friendly experience.Model and Service Enhancements:
slugfield to theSharedLinkmodel, updated constructors,copyWith, equality, and hashcode methods to includeslug.UI/UX Improvements:
SharedLinkItemwidget:slugif available and changed the URL path from/share/{key}to/s/{slug or key}.Dismissiblefor swipe-to-delete with confirmation, made the whole item tappable for editing, and enabled long-press to copy the link.How Has This Been Tested?
Screenshots (if appropriate)
Screen_Recording_20251226_185149.mp4
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
GPT-5-Codex for time selection mechanism and GitHub Copilot for PR Summary