Skip to content

fix: add missing translation key #25512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timonrieger wants to merge 3 commits into from
Closed

fix: add missing translation key #25512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bb4a1e
missing key
timonrieger Jan 25, 2026
79fcc6a
reuse exiting key
timonrieger Jan 26, 2026
5176f02
format
timonrieger Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mobile/lib/pages/editing/edit.page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ class EditImagePage extends ConsumerWidget {
.saveImage(imageData, title: "${p.withoutExtension(asset.fileName)}_edited.jpg");
await ref.read(albumProvider.notifier).refreshDeviceAlbums();
context.navigator.popUntil((route) => route.isFirst);
ImmichToast.show(durationInSecond: 3, context: context, msg: 'Image Saved!', gravity: ToastGravity.CENTER);
ImmichToast.show(
durationInSecond: 3,
context: context,
msg: 'image_saved_successfully'.tr(),
Copy link
Member

@shenlong-tanwen shenlong-tanwen Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use t extension instead of tr one?

Copy link
Collaborator Author

@timonrieger timonrieger Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference 🤔 ?

gravity: ToastGravity.CENTER,
);
} catch (e) {
ImmichToast.show(
durationInSecond: 6,
Expand Down
2 changes: 1 addition & 1 deletion mobile/lib/presentation/pages/editing/drift_edit.page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class DriftEditImagePage extends ConsumerWidget {

unawaited(ref.read(backgroundSyncProvider).syncLocal(full: true));
_exitEditing(context);
ImmichToast.show(durationInSecond: 3, context: context, msg: 'Image Saved!');
ImmichToast.show(durationInSecond: 3, context: context, msg: 'image_saved_successfully'.tr());

if (localAsset == null) {
return;
Expand Down
Loading