fix(mobile): birthday picker shows limited months when no date exists#26407
Open
socksprox wants to merge 1 commit intoimmich-app:mainfrom
Open
fix(mobile): birthday picker shows limited months when no date exists#26407socksprox wants to merge 1 commit intoimmich-app:mainfrom
socksprox wants to merge 1 commit intoimmich-app:mainfrom
Conversation
…hday exists, the picker starts at today (Feb 2026) with max also Feb 2026 — so only Jan–Feb are available for the current year. Fix applied: Added maximumDate: DateTime(DateTime.now().year, 12, 31) at person_edit_birthday_modal.widget.dart:93, allowing all 12 months to be selected while still preventing future-year birthdays.
|
Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile. A maintainer will add the required label. |
Contributor
|
Why would you pick a birthday in the future within the current year? The birthday relates to birth date which is always a past event. |
Author
You select it from left to right. All month options should be available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ScrollDatePickerdefaultsmaximumDatetoDateTime.now(). When no birthday exists, the picker starts at today (Feb 2026) with max also Feb 2026 — so only Jan–Feb are available for the current year.Fix: Added
maximumDate: DateTime(DateTime.now().year, 12, 31)atperson_edit_birthday_modal.widget.dart:93, allowing all 12 months to be selected while still preventing future-year birthdays.How Has This Been Tested?
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
An LLM (Cascade) was used to identify the root cause and generate the one-line fix.
Screenshot of tested fix, before vs after