Solving an issue with indefinite hanging on stream. #45#46
Open
benguild wants to merge 1 commit intoimmobiliare:masterfrom
benguild:master
Open
Solving an issue with indefinite hanging on stream. #45#46benguild wants to merge 1 commit intoimmobiliare:masterfrom benguild:master
benguild wants to merge 1 commit intoimmobiliare:masterfrom
benguild:master
Conversation
The main concerns are: whether or not ‘unread_bytes’ is actually populated without an fread(), and also whether or not a loop is needed with a timeout to check fread() multiple times (with an assigned timeout) or to check ‘unread_bytes’ several times within X seconds before aborting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main concerns are: whether or not ‘unread_bytes’ is actually populated without an fread(), and also whether or not a loop is needed with a timeout to check fread() multiple times (with an assigned timeout) or to check ‘unread_bytes’ several times within X seconds before aborting.