Changed strlen for binary data to take into account mbstring.func_overload#71
Open
pmxmatt wants to merge 1 commit intoimmobiliare:masterfrom
Open
Changed strlen for binary data to take into account mbstring.func_overload#71pmxmatt wants to merge 1 commit intoimmobiliare:masterfrom
pmxmatt wants to merge 1 commit intoimmobiliare:masterfrom
Conversation
Member
|
Hi, thanks but… latin1? |
Author
|
Using latin1 forces it into single-byte mode. I've tested this with both mbstring.func_overload on and off in environment and it is now counting correctly. |
Contributor
|
What's the point of checking mbstring.func_overload if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function strlen behaves differently when mbstring.func_overload is enabled for the strlen function.
This was causing the message sending to fail I've updated the code based on the comment from a user on the official documentation http://php.net/manual/en/function.strlen.php#54906 .