This repository was archived by the owner on Feb 10, 2026. It is now read-only.
Merged
Conversation
kkysen
reviewed
Nov 26, 2025
Contributor
kkysen
left a comment
There was a problem hiding this comment.
Switching to 3.12 is fine if you prefer, but don't revert the old commit (switching from 3.15 which accidentally got set because that's pre release). Also, CI is testing with 3.14 currently so I assume we'd want to match them.
Ubuntu 24.04 packages 3.12 so it would be good to be able to run on the current LTS release and I don't think we use newer Python features.
0886639 to
65baae3
Compare
Contributor
Author
3.14 is supposedly a backwards compatible release (minor version bump) and you can still test locally by running |
Contributor
|
kkysen
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know of a reason to require a very recent Python. Requiring only 3.12 means we can run out of the box (and without connectivity) on a Ubuntu 24.04 box.