Skip to content

Conversation

bungcip
Copy link
Contributor

@bungcip bungcip commented Oct 5, 2025

still WIP. because __counted_by__ only exist in clang 18, i just want to see the compile error when compiled in older clang version.

@bungcip
Copy link
Contributor Author

bungcip commented Oct 5, 2025

hmm, clang 18 also fail. in my system (clang 21) this PR can be compiled...

Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the refactor commits like f89084e and 13bae2c, just because they're so whitespace-heavy and make a big diff (even though semantically they're not large), could you put them in their own PR? You can wait until this PR is ready to review, though, in case any other changes are needed.

@bungcip bungcip force-pushed the count-attribute branch 2 times, most recently from b8dd91f to 56b6e6f Compare October 9, 2025 05:29
@bungcip
Copy link
Contributor Author

bungcip commented Oct 9, 2025

tested on clang 18, 19, and 21. not testing on 20, hopefully its working because i can compile it in 21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants