reorganize_definitions: Shorten paths that are imported into the current module #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
reviewed
Oct 7, 2025
| // If any items are imported into the current module, | ||
| // use the short paths, e.g., bar instead of crate::foo::bar | ||
| // | ||
| // TODO: this could be a separate transform |
There was a problem hiding this comment.
What transform is it part of? Reorganize definitions? It definitely seems super useful on its own.
ahomescu
force-pushed
the
ahomescu/reorganize_shorten_paths
branch
from
6aa13a0 to
21dd85a
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions
branch
from
6d527b1 to
8edb5f0
Compare
ahomescu
force-pushed
the
ahomescu/reorganize_shorten_paths
branch
from
21dd85a to
734be7a
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions
branch
from
8edb5f0 to
b6d2c9e
Compare
ahomescu
force-pushed
the
ahomescu/reorganize_shorten_paths
branch
from
734be7a to
92dd2e9
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions
branch
2 times, most recently
from
cd518be to
9804b07
Compare
ahomescu
force-pushed
the
ahomescu/reorganize_shorten_paths
branch
from
92dd2e9 to
7752cc3
Compare
ahomescu
force-pushed
the
ahomescu/reorganize_shorten_paths
branch
from
7752cc3 to
f5a88e8
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions
branch
from
9804b07 to
9b5ba1b
Compare
Base automatically changed from
ahomescu/fix_reorganize_definitions
to
master
October 14, 2025 22:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extra step to
reorganize_definitionsthat checks for every path if it is already imported into the current module, and uses the short import instead of the fully qualified path. E.g.