Skip to content

refactor: Fix transform casts from non-unit to unit types#1567

Merged
kkysen merged 1 commit intomasterfrom
ahomescu/fix_1560
Jan 29, 2026
Merged

refactor: Fix transform casts from non-unit to unit types#1567
kkysen merged 1 commit intomasterfrom
ahomescu/fix_1560

Conversation

@ahomescu
Copy link
Contributor

@ahomescu ahomescu commented Jan 24, 2026

Fixes the example from #1560 by emitting the following pattern:

    {
        let _ = crate::app::src::rng::randombytes(
            &raw mut seed as *mut ::core::ffi::c_uchar,
            (3 as ::core::ffi::c_int * crate::params_sphincs_haraka_128s_h::SPX_N)
                as ::core::ffi::c_ulonglong,
        );
        ()
    };

Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have things set up to add a test for this yet, right?

@kkysen kkysen merged commit e8d55cd into master Jan 29, 2026
11 checks passed
@kkysen kkysen deleted the ahomescu/fix_1560 branch January 29, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: 'non-primitive cast: i32 as ()' in 005_sphincs_PQCgenKAT_sign_blake_128f_simple

2 participants