Try bumping our nightly version through the power of slop-coding#1614
Try bumping our nightly version through the power of slop-coding#1614randomPoison wants to merge 7 commits intomasterfrom
Conversation
| // CHECK-DAG: pseudo-assigning fields Label { origin: Some(Origin([[R_U32_ORIGIN:[0-9]+]])){{.*}}}#&'a u32{{.*}}= Label { origin: Some(Origin({{.*}})){{.*}}&u32 | ||
| // CHECK-DAG: pseudo-assigning fields Label { origin: Some(Origin([[R_U32_ORIGIN:[0-9]+]])){{.*}}}#&'a u32{{.*}}= Label { origin: Some(Origin({{.*}})){{.*}}&u32 | ||
| // CHECK-DAG: Aggregate literal label: Label{{.*}}origin_params: [('a, Origin([[R_U32_ORIGIN]])), ('h0, Origin({{.*}})]{{.*}}#S[] | ||
| // CHECK-DAG: Aggregate literal label: Label{{.*}}#S<'_>[] |
There was a problem hiding this comment.
I'm not sure how much we care about these.
| ConstBlock(anon_const), | ||
| Call(#[prec=POSTFIX] #[prec_special=Callee] func, #[mac_table_seq] args), | ||
| MethodCall(path_seg, #[prec_first=POSTFIX] #[mac_table_seq] args, span), | ||
| MethodCall(path_seg, #[prec=POSTFIX] receiver, #[mac_table_seq] args, span), |
There was a problem hiding this comment.
This is our internal attribute, I wonder why it decided this change was needed.
| attr.style = style; | ||
| self.attrs.push(attr); | ||
| self.attrs.push(Attribute { | ||
| id: AttrId::from_u32(0), |
There was a problem hiding this comment.
We have a constant for this, DUMMY_NODE_ID I think.
| match self.kind { | ||
| // FIXME: can this conflict with regular Err literals??? | ||
| LitKind::Err(ref sym) => Some(*sym), | ||
| LitKind::Err => Some(self.token_lit.symbol), |
There was a problem hiding this comment.
Should we keep the comment?
| } | ||
| ExprKind::MethodCall(_, receiver, elements, _) => { | ||
| let mut history = Vec::with_capacity(elements.len() + 1); | ||
| for n in std::iter::once(receiver).chain(elements.iter()) { |
There was a problem hiding this comment.
No idea if this is correct, we'll have to take a close look at it later.
| config.opts.incremental = None; | ||
|
|
||
| run_in_thread_pool_with_globals(Edition::Edition2021, 1, move || { | ||
| rustc_span::create_session_globals_then(Edition::Edition2021, move || { |
There was a problem hiding this comment.
This seems extremely questionably, create_session_globals_then was around in the old nightly, and the other function did a lot more than just call it. We'll need to check what happened upstream.
| // collide with `DUMMY_SP` (which is `0 .. 0`). | ||
| source_map.new_source_file(FileName::Custom("<dummy>".to_string()), " ".to_string()); | ||
|
|
||
| let codegen_backend = get_codegen_backend( |
There was a problem hiding this comment.
Really weird that it decided to delete a bunch of code here, we need to check upstream.
2 participants
Copilot choked and died on this, but Codex seems to have succeeded. I let it spin for like an hour and it got code compiling and tests running, so let's let CI run and see if anything is broken that I didn't catch locally.