refactor: tests: port tests that panic with #[should_panic]#1618
Merged
refactor: tests: port tests that panic with #[should_panic]#1618
#[should_panic]#1618Conversation
kkysen
force-pushed
the
kkysen/refactor-tests-should_panic
branch
from
25364ba to
ef56c85
Compare
It appears this test is now broken as it panics. I still added the snapshot that should be expected based on the `new.rs` file.
kkysen
force-pushed
the
kkysen/refactor-tests-should_panic
branch
from
ef56c85 to
6233e80
Compare
ahomescu
reviewed
Feb 25, 2026
ahomescu
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still added the snapshots that should be expected based on the
new.rsfiles, so if we do fix the panic, we still have the snapshot test.