Skip to content

Fix rewrite.py to run pad-tls on all libraries including libdav1d.so #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oinoom wants to merge 1 commit into
base: ia2
Choose a base branch
from
Open

Fix rewrite.py to run pad-tls on all libraries including libdav1d.so #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rewrite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,9 +444,12 @@ def main(

for ldd in parse_ldd(ldd[dav1d]()):
padded = rpath / ldd.name
if padded.exists() and ldd.path.samefile(padded):
continue
shutil.copy(ldd.path, padded)
# Only copy if the library isn't already in rpath (e.g. libdav1d.so is
# built directly into rpath by meson, so samefile() is True). Always run
# pad-tls regardless — skipping it leaves p_align too small, causing TLS
# page sharing between compartments and SIGSEGV during exit cleanup.
if not (padded.exists() and ldd.path.samefile(padded)):
shutil.copy(ldd.path, padded)
pad_tls["--allow-no-tls", padded]()


Expand Down