fix: adding prefix for personal message sign#79
Open
MonarthS wants to merge 1 commit intoimmutability-io:masterfrom
Open
fix: adding prefix for personal message sign#79MonarthS wants to merge 1 commit intoimmutability-io:masterfrom
MonarthS wants to merge 1 commit intoimmutability-io:masterfrom
Conversation
Member
|
Can you pull from master (i drastically changed the plugin) and submit this again? |
Author
|
Okay, need to check this as I can't see the method |
Member
|
It's called sign-tx now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, the personal message sign is generated with prefix
\x19Ethereum Signed Message:\n. So compared to other, this prefix is required to get same signature as others (for ex: metamask).