Open
Conversation
…alse errors when allowing type checks on JS-files locally.
…ning the dev server. impactmakers#146" This reverts commit 1600ff6.
enjikaka
commented
Nov 5, 2019
| import styles from "./styles.module.scss"; | ||
| import buttonStyles from "../../styles/Buttons.module.scss"; | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
With JSDoc like this and JS type checking enabled in VS Code this will give you errors when specifing props wrongly or adding props that doesn't exists. Kinda handy and no need to go in fully for TypeScript or Flow in the project. Could be progressively and selectively added. :)
Type checking could also be run with the TypeScript CLI in CI like so; tsc -p jsconfig.json --noEmit
Contributor
Author
|
The test isn't properly set up for browser env? 🤔
|
Contributor
Author
|
I guess I'll have to resolve to this for the window now being defined issue. https://www.gatsbyjs.org/docs/debugging-html-builds/#how-to-check-if-window-is-defined |
nimitbhargava
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables platforms that support Web Share API, like Android, to share to all apps that allow being shared to. Just like if you were sharing from a native app.
See video here for example of sharing to Slack with this change: https://youtu.be/Ewmu4FVcF4A