Skip to content

feat: add a method for getting raw responses#28

Merged
scriptnull merged 7 commits intomainfrom
feat/add-do-raw-func
Mar 27, 2025
Merged

feat: add a method for getting raw responses#28
scriptnull merged 7 commits intomainfrom
feat/add-do-raw-func

Conversation

@scriptnull
Copy link
Collaborator

I would like a bit more control at some place. Having this will help with that.

@scriptnull scriptnull marked this pull request as ready for review March 17, 2025 11:47
@scriptnull scriptnull changed the title feat: add a method for getting Raw responses feat: add a method for getting raw responses Mar 17, 2025
@imperfect-fourth
Copy link
Owner

@scriptnull trying to understand the need here. Can you give an example use case of why/where you would need the raw http response object?

@scriptnull
Copy link
Collaborator Author

sure. There is a place where I am doing Do() to perform a gql request and it is returning error response with http status code: %d error. I can see the HTTP status code with that error, but there is more useful information in the response body about the error which I would like to access. Having Raw() would give me a way to access that information.

@scriptnull
Copy link
Collaborator Author

I belive Do can also use Raw as it is superset of that functionality. Would you like me to do that as part of this PR?

@imperfect-fourth
Copy link
Owner

cool! let's make Do use Raw

scriptnull and others added 2 commits March 20, 2025 11:02
Co-authored-by: Divyansh Verma <divyansh@hasura.io>
@scriptnull scriptnull merged commit 2e338a5 into main Mar 27, 2025
2 checks passed
@scriptnull scriptnull deleted the feat/add-do-raw-func branch March 27, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants