Add support for SET syntax and trailing semicolons#89
Merged
vogievetsky merged 8 commits intomasterfrom Apr 15, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 212d41e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vogievetsky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support changes coming from apache/druid#17894
Note that I decided to incorporate the
SETstatements into theSqlQueryand semicolons into spacing versus the more SQL-y alternative of introducing a concept of aSqlStatementList. I believe that while my approach is less SQL-y it is closer to the underlying meaning behind DruidSQL and therefore will be easier to work with.Also downgrade prettier to version 2.x (which resulted in the re-formatting of
pattern-number-range.ts) so that it is possible to update inline snapshots and runnpm audit fixfor fix issues reported in the audit.