Update uglify js package for make web demo#4
Open
begroff wants to merge 1 commit intoimposters-handbook:masterfrom
Open
Update uglify js package for make web demo#4begroff wants to merge 1 commit intoimposters-handbook:masterfrom
begroff wants to merge 1 commit intoimposters-handbook:masterfrom
Conversation
- The old uglifyjs package that was originally used has been deprecated in favor of uglify-js. Updated the package.json to reflect this so the makefile works properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While watching the make video and running through the web tutorial, I ran into an error running the makefile. It was having an issue with uglifying the JavaScript.
The original package was set to uglifyjs. When I went to that folder, there was a message there indicating uglifyjs has been deprecated and you should use uglify-js instead. I have updated the package.json to reflect the new package.
I ran the makefile and everything works as expected now. Thanks for the videos!