Skip to content

Conversation

@glaubersilva
Copy link
Contributor

@glaubersilva glaubersilva commented Dec 23, 2025

Resolves GIVE-2646

Description

This PR adds a new email that is sent to the admin when a donation gets the status changes do failed.

Affects

Admin email notifications

Visuals

image image image

Testing Instructions

  1. Create a test donation
  2. Set the donation status to Failed
  3. Make sure the new email was sent to the admin

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Relevant @unreleased tags included in DocBlocks
  • Includes unit tests
  • Reviewed by the designer (if follows a design)
  • Self Review of code and UX completed

@glaubersilva glaubersilva self-assigned this Dec 23, 2025
@glaubersilva glaubersilva marked this pull request as ready for review December 23, 2025 19:52
@jonwaldstein
Copy link
Contributor

@glaubersilva FYI I think there's 2 parts to this task that we'll need to decipher from the feedback.

  1. Admin email: A donation status changes to failed (this PR)
  2. Admin email: A subscription is marked as failing (a separate PR)

A version of #2 technically exists for the donor side but people also want to be notified as the admin.

Screenshot 2026-01-05 at 2 43 14 PM

@jonwaldstein jonwaldstein self-requested a review January 5, 2026 19:53
Copy link
Contributor

@jonwaldstein jonwaldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready for QA 🌈

@glaubersilva
Copy link
Contributor Author

@jonwaldstein I agree we need to create a new email for subscription failing to be sent for the admin, but I'll create a new task for that for better tracking and QA purposes.

Copy link

@Robincredible Robincredible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed

@glaubersilva glaubersilva merged commit fd63872 into develop Jan 16, 2026
24 checks passed
@glaubersilva glaubersilva deleted the feature/admin-failed-donation-email-GIVE-2646 branch January 16, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants