Fix admin confirm/refuse backend actions #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patta
reviewed
Oct 24, 2025
| 'userConfirmationRefused', 'confirmDeletion' => $this->statusUserConfirmationRefused($user, $hash), | ||
| 'adminConfirmation', 'confirmAdmin' => $this->statusAdminConfirmation($user, $hash, $status, $backend), | ||
| 'adminConfirmationRefused', 'adminConfirmationRefusedSilent', 'confirmAdminDeletion', 'confirmAdminDeletionSilent' => | ||
| 'adminConfirmationRefused', 'adminConfirmationRefusedSilent', 'confirmAdminDeletion', 'confirmAdminRefused', 'confirmAdminDeletionSilent' => |
Contributor
There was a problem hiding this comment.
confirmAdminDeletionSilent must be replaced by confirmAdminRefusedSilent to make the silent admin deletion work. see:
Contributor
There was a problem hiding this comment.
Additionally, the status confirmAdminRefusedSilent must be included in the if statement with && to prevent the email notification from being sent to the user:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with the backend confirmation module, for one, that neither confirm/refuse functioned properly, and refuse effectively doing nothing anymore.
Both buttons now do what they are supposed to do again.
Testing notice: You need to enable the extension configuration "Enable confirmation view" to see the module in question.
And also set following TypoScript to enable the error cases with confirmations, as they came about with the double opt-in feature:
Fixes #668
Fixes #639
Fixes #665
Fixes #108 (not explicitly a double opt-in/confirm issue, but an easy enough fix to be included)