Updated calls to selenium.webdriver.find_element_by_id#56
Open
Charl-X wants to merge 1 commit intoinAudible-NG:masterfrom
Open
Updated calls to selenium.webdriver.find_element_by_id#56Charl-X wants to merge 1 commit intoinAudible-NG:masterfrom
Charl-X wants to merge 1 commit intoinAudible-NG:masterfrom
Conversation
…ver.find_element(By.ID, ...) to fix an error when running the Firefox web driver.
|
Running audible-activator.py with the latest chromedriver at the time of installation through brew yields the same error and is fixed by the same fix. $ chromedriver -v |
|
please merge this. And also... please freeze dependencies version in requirements.txt to avoid such situations in the future. |
|
I was about to make the same PR ... Thanks @inAudible-NG for your work, really appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the original audible-activator.py script with the Firefox web driver results in the error:
Traceback (most recent call last):
File "audible-activator.py", line 202, in
fetch_activation_bytes(username, password, options)
File "audible-activator.py", line 102, in fetch_activation_bytes
search_box = driver.find_element_by_id('ap_email')
AttributeError: 'WebDriver' object has no attribute 'find_element_by_id'
I updated these calls to have the intended functionality by importing By from selenium.webdriver.common.by:
search_box = driver.find_element(By.ID, 'ap_email')