-
Notifications
You must be signed in to change notification settings - Fork 0
✨ Create test model for KF study #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
awarkow
wants to merge
63
commits into
main
Choose a base branch
from
kf-test-study
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate custom schema name from folder structure
add source tables to src schema from imports
don't select timestamps from src
add questions about pt vis fields
merging ph and dx ds tables
awarkow
commented
Dec 17, 2025
dbt_project/models/kids_first/sd_1nns3k8v/int/int_conditions.sql
Outdated
Show resolved
Hide resolved
awarkow
commented
Dec 17, 2025
dbt_project/models/kids_first/sd_1nns3k8v/int/int_conditions.sql
Outdated
Show resolved
Hide resolved
awarkow
commented
Dec 17, 2025
dbt_project/models/kids_first/sd_1nns3k8v/int/int_conditions.sql
Outdated
Show resolved
Hide resolved
awarkow
commented
Dec 17, 2025
dbt_project/models/kids_first/sd_1nns3k8v/int/int_conditions.sql
Outdated
Show resolved
Hide resolved
awarkow
commented
Dec 17, 2025
dbt_project/models/kids_first/sd_1nns3k8v/int/int_conditions.sql
Outdated
Show resolved
Hide resolved
awarkow
commented
Dec 17, 2025
| kf_id as family_id, | ||
| lower(replace(kf_id, '_', '-')) as dewrangle_family_id, | ||
| external_id, | ||
| family_type, -- not historically populated but it should be; can use logic rules to calculate |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed that this would be useful to populate
add every ds field, and comments for eval
add logic case for output schema for seed files
…ndbox into kf-test-study
fix naming for non-nested folders in models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create model for KF test study (SD_1NNS3K8V)
This PR creates example models for a KF study, using source data from the existing Kids First Dataservice. To build the model, users will need to download source files from DS to load as seed files before running dbt.
Please reach out to @awarkow or @Christina-J-Diaz for these seed files.
Continues ongoing work under DFF Epic D3B-2115
Type of change
to not work as expected)
TODO: Implement tests and run through checklist
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration
Test Configuration:
Checklist
Please check all of the items below before merging this pull request. If an
item in the list below does not need to be completed, please indicate the
reason why.
the start of each script
works
sqlfluff fixon tables that are created or modified in this PR.