Refactor namespace configuration to use global.namespace#68
Refactor namespace configuration to use global.namespace#68lanmaoxinqing wants to merge 1 commit intomainfrom
Conversation
- Replace all .Values.metadata.namespace with .Values.global.namespace across all sub-chart templates - Remove metadata.namespace configuration from parent and sub-chart values.yaml files - Update _helpers.tpl files to use .Values.global.namespace for service address generation - Remove sandbox namespace OSS secret creation from envhub - Preserve sandboxNamespace configuration for controller pod templates Changes include: - deploy/values.yaml: Remove metadata.namespace from all sub-chart configurations - deploy/api-service/, deploy/controller/, deploy/envhub/, deploy/redis/: - Update templates to use .Values.global.namespace - Remove metadata.namespace from values.yaml - deploy/*/templates/_helpers.tpl: Update helper functions to use .Values.global.namespace
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the namespace configuration within the Helm charts to establish a unified approach using a global namespace variable. This change centralizes the definition of the Kubernetes namespace, making deployments more consistent and easier to manage by removing redundant and potentially conflicting namespace declarations from individual sub-charts. The update also includes minor image version bumps for several components. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the Helm charts to use a centralized global.namespace, which is a great improvement for maintainability. The changes are consistent across all sub-charts. However, I've found a critical issue in deploy/Chart.lock where the api-service dependency is duplicated, which needs to be fixed. Additionally, there appears to be an inconsistency with the PR description regarding the removal of the sandbox namespace OSS secret in the envhub chart; the logic seems to remain and references a potentially undefined value (.Values.global.sandboxNamespace). Please double-check this part of the implementation.
| - name: api-service | ||
| repository: file://./api-service | ||
| version: 0.0.1 |
There was a problem hiding this comment.
The api-service dependency is duplicated. This will likely cause issues with Helm. Please remove this duplicated block.
2 participants
Changes include: