-
Notifications
You must be signed in to change notification settings - Fork 243
feat: extract tool output from openai-agents sdk #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract tool output from openai-agents sdk #507
Conversation
Summary of ChangesHello @CormickKneey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the OpenAI Agents SDK integration by refining how tool outputs are processed and how various parameters are validated. The changes ensure that custom tool outputs are correctly converted to the standard OpenAI chat template and that parameters like Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the OpenAI Agents SDK integration by introducing helper functions to handle tool output conversion and parameter validation. The new _convert_tool_output_format function correctly transforms custom tool outputs, and the is_omitted function provides a centralized way to check for omitted parameters, improving code clarity and robustness. My review includes a couple of suggestions to further improve the reliability of these new helper functions.
9760151 to
9e4d99a
Compare
9e4d99a to
1635700
Compare
dhh1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
Signed-off-by: CormickKneey <[email protected]>
1635700 to
4665b69
Compare
fishcrap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: CormickKneey <[email protected]>
Signed-off-by: CormickKneey <[email protected]>
Description
This PR enhances the OpenAI Agents SDK integration in AReaL by adding proper tool output format conversion and improving parameter handling. The changes ensure compatibility with the OpenAI chat template format and fix parameter validation issues.
Key improvements:
{"call_id": "call_b072608844e54c8ea88379cb", "output": "root@3f3f8caec37b:/app# ls -l process_data.sh\n-rw-r--r-- 1 root root 49 Oct 15 09:38 process_data.sh\nroot@3f3f8caec37b:/app#\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n\n", "type": "function_call_output"}NOT_GIVENandOmittypes from the OpenAI SDKRelated Issue
Fixes # (issue number - please update if there's a specific issue)
Type of Change
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
No breaking changes - this is a backward-compatible enhancement that improves tool output handling.
Additional Context