-
Notifications
You must be signed in to change notification settings - Fork 271
[wip] feat: support agent workflow with openai proxy #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @garrett4wade, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's capabilities by introducing a robust framework for integrating agent-based workflows, particularly through an OpenAI-compatible proxy. This allows developers to define complex agent behaviors using familiar OpenAI SDKs, which then interact with the underlying inference engine. The changes involve new abstract classes for agents, a dedicated proxy server for managing agent interactions and rewards, and a refactored workflow resolution mechanism that seamlessly integrates these new agent types into the existing rollout and training pipelines. This streamlines the development of sophisticated reinforcement learning agents that leverage large language models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and well-structured feature to support agent-based workflows using an OpenAI-compatible proxy. The core of the change is the AgentWorkflow abstraction, which allows users to integrate agentic logic into the training pipeline seamlessly. The refactoring of the proxy logic and the simplification of the WorkflowExecutor are commendable design choices. However, I've identified a few issues: a misleading comment in a utility function, some dead code in the new proxy workflow module, a broken test due to an incorrect constructor call, and a broken example that relies on a removed API. Addressing these points will further improve the quality of this feature.
| *[self._run_episode(task_id, data) for _ in range(self.group_size)] | ||
| ) | ||
| await ProxyServer.finish_task(task_id, base_url=self.base_url) | ||
| await OpenAIProxyServer.finish_task(task_id, base_url=self.base_url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example attempts to call OpenAIProxyServer.finish_task, but this method does not exist on the OpenAIProxyServer class. This method was present in the old ProxyServer but was removed during the refactoring. The new proxy server uses a capacity-based mechanism and does not have a finish_task endpoint. This example is broken and needs to be updated to work with the new proxy server design.
b90bd72 to
5c267b1
Compare
Description
Related Issue
Fixes #(issue)
Type of Change
work as expected)
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
Additional Context
Need help? Check the Contributing Guide or ask in
GitHub Discussions!