feat: add strategies palette to make use of vocabulary strategies for finding symbols#24
Draft
klown wants to merge 11 commits intoinclusive-design:mainfrom
Draft
feat: add strategies palette to make use of vocabulary strategies for finding symbols#24klown wants to merge 11 commits intoinclusive-design:mainfrom
klown wants to merge 11 commits intoinclusive-design:mainfrom
Conversation
Pushing to the navigation stack includes the html element wherein the palette was rendered so that when going back to it, it is rendered in the same place. This allows different areas of the adaptive-palette to navigate to different palettes.
This move is to match the move of all of the `src` files to the `client` folder as part of the express server work (`feat/setup-server-src`).
- Not needed: aria-controls was used for the id of the element wherein to render the go-back palette, but that id is now stored with the go-back palette, - Confusing: if the code continued to use aria-controls, then its value would change depending on which go-back render element is currently relevant. But, changing that value is likely confusing to an AT user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This adds a "Strategies" palette and its sub-layers for selecting among various ways to help the user find a specific Bliss symbol.
A new type of cell is introduced here, namely the
LabelCell(a Preact component). Its purpose is to label the palette that it is part of. In terms of HTML, the component is rendered as a<label>element, but it is unlikely that this right way to provide the label.To Do:
ActionBmwCodeCellcomponents, but they should cause the strategy to "work".LabelCelland the palette it labels, e.g., by adding anaria-labelledbyoraria-labelto the appropriate place,LabelCell,Note that this PR includes the changes from #23.
This PR replaces a previous PR that was not based on the
mainbranch. The code has been appropriately re-based and this new PR issued.