feat: add the multi-languages support into the Bliss dictionary#46
Open
cindyli wants to merge 6 commits intoinclusive-design:mainfrom
Open
feat: add the multi-languages support into the Bliss dictionary#46cindyli wants to merge 6 commits intoinclusive-design:mainfrom
cindyli wants to merge 6 commits intoinclusive-design:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run testwithout errorsnpm run buildwithout errorsDescription
This PR replaces the use of
public/data/bliss_symbol_explanations.jsonwithpublic/data/bliss_dict_multi_langs.json.This PR is based on #43 that should be reviewed and merged first.
Steps to test
Expected behavior:
Make sure the application works fine.
Additional information
Before this PR is merged, the multi-lang supported dictionary file is not in the main branch. After the code review and before the merge, for these two lines of code, the first line should be removed and the commented line should be uncommented to point to the dictionary file in the main branch.