Skip to content

Initial commit for group membership reminder #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sae126V wants to merge 2 commits into
base: develop
Choose a base branch
from
+478 −2

FIx code smell

fb42fd8
Select commit
Loading
Failed to load commit list.
Open

Initial commit for group membership reminder #1184

FIx code smell
fb42fd8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 9, 2026 in 58s

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 104 in iam-login-service/src/main/java/it/infn/mw/iam/core/web/group/GroupRequestReminderTask.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=indigo-iam_iam&issues=AZzR52slUd8x_waMKso-&open=AZzR52slUd8x_waMKso-&pullRequest=1184

Check failure on line 167 in iam-login-service/src/main/java/it/infn/mw/iam/notification/TransientNotificationFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "notes" 3 times. 

See more on https://sonarcloud.io/project/issues?id=indigo-iam_iam&issues=AZzR52vpUd8x_waMKspE&open=AZzR52vpUd8x_waMKspE&pullRequest=1184

Check warning on line 28 in iam-login-service/src/main/java/it/infn/mw/iam/core/web/group/GroupRequestReminderTask.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.springframework.beans.factory.annotation.Autowired'. 

See more on https://sonarcloud.io/project/issues?id=indigo-iam_iam&issues=AZzS69ZSzSB7bvLM1FWD&open=AZzS69ZSzSB7bvLM1FWD&pullRequest=1184

Check failure on line 165 in iam-login-service/src/main/java/it/infn/mw/iam/notification/TransientNotificationFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "%s/dashboard#!/requests" 3 times. 

See more on https://sonarcloud.io/project/issues?id=indigo-iam_iam&issues=AZzR52vpUd8x_waMKspF&open=AZzR52vpUd8x_waMKspF&pullRequest=1184

Check failure on line 165 in iam-login-service/src/main/java/it/infn/mw/iam/notification/TransientNotificationFactory.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "indigoDashboardUrl" 3 times. 

See more on https://sonarcloud.io/project/issues?id=indigo-iam_iam&issues=AZzR52vpUd8x_waMKspG&open=AZzR52vpUd8x_waMKspG&pullRequest=1184

Check warning on line 33 in iam-login-service/src/main/java/it/infn/mw/iam/core/web/group/GroupRequestReminderTask.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'it.infn.mw.iam.core.oidc.EntityConfigurationBuilder'. 

See more on https://sonarcloud.io/project/issues?id=indigo-iam_iam&issues=AZzS69ZSzSB7bvLM1FWE&open=AZzS69ZSzSB7bvLM1FWE&pullRequest=1184
View more details on SonarQubeCloud