Comparison operators for PwAff #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
commented
Sep 11, 2023
| :return: self <= other | ||
| """ | ||
| if isinstance(other, int): | ||
| return self.le_set(self * 0 + other) |
Contributor
Author
There was a problem hiding this comment.
There must be a better way to do this.
Owner
There was a problem hiding this comment.
zero = Aff.zero_on_domain(LocalSpace.from_space(space))
result[0] = PwAff.from_aff(zero)
inducer
reviewed
Sep 11, 2023
Comment on lines
+734
to
+737
| PwAff.__le__ = pw_le | ||
| PwAff.__lt__ = pw_lt | ||
| PwAff.__ge__ = pw_ge | ||
| PwAff.__gt__ = pw_gt |
Owner
There was a problem hiding this comment.
One issue with this is that it can't extend to == and !=. I wonder whether that invalidates the idea...
Contributor
Author
There was a problem hiding this comment.
True. This is a problem for eg: SymPy where == and != are structural equivalence and Eq gives an expression. Numpy however is consistent and implements == and != and returns a numpy array of bools.
| PwAff.__lt__ = pw_lt | ||
| PwAff.__ge__ = pw_ge | ||
| PwAff.__gt__ = pw_gt | ||
| PwAff.__bool__ = pw_bool |
Owner
There was a problem hiding this comment.
You need to override __bool__ on Set.
| :return: self <= other | ||
| """ | ||
| if isinstance(other, int): | ||
| return self.le_set(self * 0 + other) |
Owner
There was a problem hiding this comment.
zero = Aff.zero_on_domain(LocalSpace.from_space(space))
result[0] = PwAff.from_aff(zero)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.