debian-packaging: Fix missing tilde case in lexical comparisons #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in indygreg#11, I derived the overall structure of the resulting `match` block from combining the tilde / end-of-string comparisons from the former one + the tilde alphanumeric comparisons from `compare_char`. Unfortunately, in the process, an important case got omitted: comparing any character on the left to a tilde on the right, which was incorrectly replaced with comparing to end-of-string on the left. This restores the correct match branch, as well as regrouping the comparisons and adding extra comments for readability. Signed-off-by: Ryan Gonzalez <[email protected]>
refi64
added a commit
to collabora/aptly-rest-tools
that referenced
this pull request
May 27, 2025
The original goal was to update linux-packaging-rs to instead point to indygreg/linux-packaging-rs#27, but that caused some dependency conflicts, so it's easier to just update everything in one go. Signed-off-by: Ryan Gonzalez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #11, I derived the overall structure of the resulting
matchblock from combining the tilde / end-of-string comparisons from the former one + the tilde alphanumeric comparisons fromcompare_char. Unfortunately, in the process, an important case got omitted: comparing any character on the left to a tilde on the right, which was incorrectly replaced with comparing to end-of-string on the left.This restores the correct match branch, as well as regrouping the comparisons and adding extra comments for readability.