Move setuptools constraint to where --build-option is used #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of restricting the version of setuptools used to build zstandard in every case, only limit it where necessary. This allows to pick setuptools fixes, like proper detection of newer versions of MSVC.
indygreg
approved these changes
Feb 9, 2025
Owner
indygreg
left a comment
indygreg
left a comment
There was a problem hiding this comment.
I'm fine with this hack. Pinning to older setuptools was likely only going to work for so long before other things blew up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of restricting the version of setuptools used to build zstandard in every case, only limit it where necessary. This allows to pick setuptools fixes, like proper detection of newer versions of MSVC.
As a side effect, this fixes #240.