Skip to content

ext: Use new C API for unique references #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ext: Use new C API for unique references #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f599169
ext: update pythoncapi-compat
ngoldbaum Sep 1, 2025
48fb689
ext: use new C API for unique references
ngoldbaum Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion c-ext/backend_c.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ size_t roundpow2(size_t i) {
int safe_pybytes_resize(PyObject **obj, Py_ssize_t size) {
PyObject *tmp;

if (Py_REFCNT(*obj) == 1) {
if (PyUnstable_Object_IsUniquelyReferenced(*obj)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a note that using the Unstable API may require reinspecting this every time a new minor Python is bumped?

Other than this, LGTM

return _PyBytes_Resize(obj, size);
}

Expand Down
Loading
Loading