Skip to content

[2.x] Refactored ssr.dispatch_without_bundle to ssr.ensure_bundle_exists #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

[2.x] Refactored ssr.dispatch_without_bundle to ssr.ensure_bundle_exists #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/inertia.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

'url' => env('INERTIA_SSR_URL', 'http://127.0.0.1:13714'),

'dispatch_without_bundle' => (bool) env('INERTIA_SSR_DISPATCH_WITHOUT_BUNDLE', false),
'ensure_bundle_exists' => (bool) env('INERTIA_SSR_ENSURE_BUNDLE_EXISTS', true),

// 'bundle' => base_path('bootstrap/ssr/ssr.mjs'),

Expand Down
2 changes: 1 addition & 1 deletion src/Ssr/HttpGateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function isHealthy(): bool
*/
protected function shouldDispatchWithoutBundle(): bool
{
return config('inertia.ssr.dispatch_without_bundle', false);
return ! config('inertia.ssr.ensure_bundle_exists', true);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions tests/HttpGatewayTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ public function test_it_uses_the_configured_http_url_when_the_bundle_file_is_det
$this->assertEquals('<div id="app">SSR Response</div>', $response->body);
}

public function test_it_uses_the_configured_http_url__when_bundle_file_detection_is_disabled()
public function test_it_uses_the_configured_http_url_when_bundle_file_detection_is_disabled()
{
config([
'inertia.ssr.enabled' => true,
'inertia.ssr.dispatch_without_bundle' => true,
'inertia.ssr.ensure_bundle_exists' => false,
'inertia.ssr.bundle' => null,
]);

Expand Down