fix incorrect df_check_filesystem_single calling. #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the always returning of "no filesystem information" for the df_check_filesystem_single call since this function expected the reserved_space to be != None. In addition, the size parameters are now properly converted to MiB to match expectactions.
Contributor
Author
|
See here for the error (note the "no filesystem size information" being printed): 
And here after the fix (after adding 
Also note that TiB is printed correctly. Furthermore, please note the following reference to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the always returning of "no filesystem information" for the df_check_filesystem_single call since this function expected the reserved_space to be != None. In addition, the size parameters are now properly converted to MiB to match expectations.