[1.20.1] Fixed item tab and tooltip translations, customizable tooltips #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in gem tooltips, made gem tooltips customizable
SwanX1
requested review from
Dariensg and
nekomaster1000
and removed request for
Dariensg
Member
Author
|
@nekomaster1000 I hope this PR is acceptable to the development of Resurvival (as opposed to auto-generated tooltips) |
SwanX1
changed the title
Jonathing
previously requested changes
Feb 24, 2025
Jonathing
dismissed
their stale review
The reviewed changes were intentionally made.
Jonathing
reviewed
Feb 24, 2025
Comment on lines
+23
to
+25
| for (String line : tooltipText.split("\n")) { | ||
| tooltip.add(Component.literal(line)); | ||
| } |
There was a problem hiding this comment.
Note that this will not preserve color codes at the beginning of the string in the lang json. You should make sure to communicate this somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the creative item tab correctly use the lang entry for its name, moved item tooltips into lang entries, and added optional tooltip customization for modpack devs.
You still need to press shift to see the tooltip in the above screenshot