[1.19.2] Enqueue client setup to avoid concurrency issues #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name entails.
ClientEvents.setup()callsinitShields()which registers item property functions for each of the shields. Registering item property functions without usingevent.enqueueWork()has historically caused semi-frequent crashes with other mods that also add item property functions, because the item property functions map cannot be concurrently modified.Also, there is no need to use
DistExecutorhere. The client setup event is only ever fired for the client, and the extra redundancy here will hurt maintainability down the line.