Skip to content

Conversation

@karlnaden
Copy link
Contributor

@karlnaden karlnaden commented Dec 31, 2025

Summary

Major CRD Client test suite update targeted at supporting more control over hook responses when using the custom response approach. Additional updates made where related and also performed a documentation overhaul. Specific changes included:

  • Fixed incorrect format for action.resourceId: was array, now is string
  • Removed warning when no cards returned but system actions were
  • Separated out the logic for determining the CRD card type
  • Added logic to the hook endpoint allow for dynamic custom responses
  • Moved validation of the custom response from the static version to the dynamic versions
  • Added ability to add additional tags beyond the hook name for use in derivative tests
  • Updated the display attestation to look at the cards and actions returned, not just those selected
  • Add Wiki and overhaul test kit documentation following the pattern of the PAS test kit

Testing Guidance

  • Verify behavior using the complete example on the wiki page, leveraging the instructions to run the client and server test suites against each other. Follow the listed steps with the following exceptions:
    • In step 4, run the Client "order-sign" hook test instead of "appointment-book" and use the example template for the "Custom response for order-sign hook requests" input.
    • In step 8, run the Server "order-sign" hook test instead of "Demonstrate A Hook Response" and update the "Request body or bodies for invoking the order-sign hook" input to be a json list of requests with the two sample requests (here, and here) as entries.
    • After the tests have been run, use either suite to find the two requests made and compare the responses against the expected responses in the wiki (for patient pat015, for patient 888)
  • Try to use the instructions to setup one or more additional template and test that they work against some requests. Can you follow the instructions to create the template? Do the configuration options support the scenario, or is something more needed to make it possible (or simpler)?
    • For example, a scenario to try would be: always say PA required with additional documentation needed, but return different questionnaires: for service request order A, ask for questionnaire X, for other service requests ask for questionnaire Y, for other resource types ask for questionnaire Z.
  • Review documentation wiki.

@karlnaden karlnaden marked this pull request as ready for review January 7, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants