Skip to content

Conversation

@euvre
Copy link
Contributor

@euvre euvre commented Jan 23, 2026

What problem does this PR solve?

1.If the data is not in working_dir(tmp_dir) but in persistence or data_dir, the previous implementation would fail.
2.Fix the mismatch between the order of BlockVersion members and the older version.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@euvre euvre added the ci PR can be test label Jan 23, 2026
@euvre euvre marked this pull request as ready for review January 23, 2026 05:19
@euvre euvre force-pushed the fix_working_dir_bug branch 2 times, most recently from f5f9701 to f291e95 Compare January 23, 2026 07:22
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 82.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.06%. Comparing base (0062d8d) to head (6048268).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/storage/io/virtual_store_impl.cpp 56.25% 9 Missing and 5 partials ⚠️
src/storage/catalog/meta/block_version_impl.cpp 86.36% 2 Missing and 1 partial ⚠️
...r/file_worker/secondary_index_file_worker_impl.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3216      +/-   ##
==========================================
- Coverage   49.30%   47.06%   -2.25%     
==========================================
  Files         729      729              
  Lines      151217   151228      +11     
  Branches    27264    27267       +3     
==========================================
- Hits        74563    71175    -3388     
- Misses      66651    70405    +3754     
+ Partials    10003     9648     -355     
Flag Coverage Δ
debug http test ?
debug parallel test ?
debug pysdk test 29.88% <68.00%> (+0.01%) ⬆️
debug sqllogical test 30.78% <42.00%> (-0.01%) ⬇️
debug unit test 37.23% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@euvre euvre force-pushed the fix_working_dir_bug branch 3 times, most recently from 69c8c1e to 3202c4b Compare January 23, 2026 12:21
Signed-off-by: noob <[email protected]>
@euvre euvre force-pushed the fix_working_dir_bug branch from 3202c4b to ac7cb65 Compare January 23, 2026 12:22
Signed-off-by: noob <[email protected]>
@euvre euvre force-pushed the fix_working_dir_bug branch from 6989a29 to 656484e Compare January 23, 2026 13:13
euvre added 4 commits January 23, 2026 21:36
Signed-off-by: noob <[email protected]>
Signed-off-by: noob <[email protected]>
Signed-off-by: noob <[email protected]>
Signed-off-by: noob <[email protected]>
@euvre euvre force-pushed the fix_working_dir_bug branch from 7589450 to 6048268 Compare January 26, 2026 04:28
@yuzhichang yuzhichang merged commit f49df33 into infiniflow:main Jan 26, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci PR can be test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants