Skip to content

Comments

refactor(embedding): remove zhipuai sdk and dependency for ZHIPU embeddings#13076

Open
yuehong136 wants to merge 1 commit intoinfiniflow:mainfrom
yuehong136:codex/remove-zhipuai-embedding
Open

refactor(embedding): remove zhipuai sdk and dependency for ZHIPU embeddings#13076
yuehong136 wants to merge 1 commit intoinfiniflow:mainfrom
yuehong136:codex/remove-zhipuai-embedding

Conversation

@yuehong136
Copy link
Contributor

@yuehong136 yuehong136 commented Feb 9, 2026

What problem does this PR solve?

This PR removes the zhipuai Python SDK dependency from the ZHIPU embedding implementation and switches embedding calls to the official HTTP endpoint (/paas/v4/embeddings), reducing dependency overhead while keeping behavior unchanged.

Type of change

  • Refactoring

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ☯️ refactor Pull request that refactor/refine code labels Feb 9, 2026
@KevinHuSh KevinHuSh added the ci Continue Integration label Feb 11, 2026
@KevinHuSh KevinHuSh marked this pull request as draft February 11, 2026 01:52
@KevinHuSh KevinHuSh marked this pull request as ready for review February 11, 2026 01:52
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.05%. Comparing base (4bc622b) to head (478d157).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13076      +/-   ##
==========================================
- Coverage   44.12%   44.05%   -0.07%     
==========================================
  Files          43       43              
  Lines        9394     9415      +21     
  Branches      107      107              
==========================================
+ Hits         4145     4148       +3     
- Misses       5230     5248      +18     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asiroliu
Copy link
Collaborator

@yuehong136
Thank you very much for your PR. However, I believe moving away from the official Zhipu SDK in favor of a manual implementation is unnecessary and will make the code harder to maintain when the model changes in the future.

@KevinHuSh KevinHuSh removed the ci Continue Integration label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☯️ refactor Pull request that refactor/refine code size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants