Fix: empty response from OpenAI chat completion endpoint#13166
Open
as-ondewo wants to merge 2 commits intoinfiniflow:mainfrom
Open
Fix: empty response from OpenAI chat completion endpoint#13166as-ondewo wants to merge 2 commits intoinfiniflow:mainfrom
as-ondewo wants to merge 2 commits intoinfiniflow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When using a chat assistant that has a hardcoded
empty_response, that response was not returned correctly in streaming mode when no information is found in the knowledge base. In this case only one response with"content": nullwas yielded. If"references": true, then theempty_responseis still put into thefinal_contentso there is technically some content returned, but when"references": falseno content at all is returned.I update the OpenAI chat completion endpoint to yield an additional response with the
empty_responsein the content.Type of change