feat: Elasticsearch access via API Key#13167
Open
leonardlin wants to merge 1 commit intoinfiniflow:mainfrom
Open
feat: Elasticsearch access via API Key#13167leonardlin wants to merge 1 commit intoinfiniflow:mainfrom
leonardlin wants to merge 1 commit intoinfiniflow:mainfrom
Conversation
dosubot
bot
added
size:M
Author
|
@Magicbook1108 @KevinHuSh this is the updated PR |
fixed local configuration feat: Elasticsearch access via API Key: reverse testconfig feat: Elasticsearch access via API Key: reverse testconfig
leonardlin-maintmaster
force-pushed
the
main
branch
from
3a0f561 to
ddb1450
Compare
|
Exactly what's the point of Basic Auth when the Elastic Cloud provided default API is based on endpoint + API Key? Shockingly bad decision to build something with basic auth. @click.option("--es-user", default=None, help="Elasticsearch username") Can I plase also request you do NOT default the endpoint of ES cloud to 9200 pls? The ES cloud's default provided port is 443 not 9200 @click.option("--es-port", default=9200, type=int, help="Elasticsearch port") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As requested: #10321
Elasticsearch configuration uses username/password.
In order to use external / cloud hosted elasticsearch, we need to enable API-Key based authentication.
Following changes:
Adds ELASTIC_API_KEY as configuration
Connection Pool checks if APIKey is present and tries to use it
HelmChart allows to disable the elasticsearch deployment
Type of change