Add post-add event to collection js#64
Add post-add event to collection js#64ste-wilkinson wants to merge 6 commits intoinfinite-networks:masterfrom ste-wilkinson:master
Conversation
merk
left a comment
merk
left a comment
There was a problem hiding this comment.
Thanks!
I'm curious, what do you need the event for?
And could you please add some tests for this change, the modifications have broken the current tests (while our travis builds look to be failing, there is output from the HHVM one: https://travis-ci.org/infinite-networks/InfiniteFormBundle/jobs/201476742#L343)
Resources/doc/collection-helper.md
Outdated
| prototype will be the add button. In the case of the | ||
| Polycollection, the prototype will be one of the prototype | ||
| buttons. | ||
| - `$row`: the jQuery wrapped DOM elements that was added to the collection. |
There was a problem hiding this comment.
grammar: dom elements that were added
Resources/public/js/collections.js
Outdated
| if (!addEvent.isDefaultPrevented()) { | ||
| if (event.insertBefore) { | ||
| $row.insertBefore(event.insertBefore); | ||
| this.$collection.trigger(addedEvent); |
There was a problem hiding this comment.
This can be moved below the if and before the return to avoid repeating the same call in both branches.
You should also only create the event before it is about to be fired, inside the isDefaultPrevented() check.
|
Hi Merk, Sure, I'll add the tests later today :) The reason we need the post-add event is for visual purposes really: items within the polycollection are styled in a way that allows them to act as a kind of editable preview, but we also allow the user to change the aspect ratio of the previews in a dropdown, so in the case that a user changes the resolution and then adds a new element, the prototype is unaware of the new resolution when it is created, so the event helps us hook into that and resize. If that makes sense? |
|
Hi Merk, looks like there's a failing php test on the 177.5 build only, even though this PR involves no php changes. Is this a known issue? |
|
The test failure is unrelated to your changes, I made some updates to fix our travis config and there is still a problem with PHP5.6 and our legacy symfony support for the Polycollection. |
3 participants
No description provided.