Skip to content

3.0.1#61

Closed
iobrado wants to merge 2 commits intomainfrom
feature/update-dependencies
Closed

3.0.1#61
iobrado wants to merge 2 commits intomainfrom
feature/update-dependencies

Conversation

@iobrado
Copy link
Copy Markdown
Contributor

@iobrado iobrado commented Feb 23, 2026

Description

Changed

  • Updated dependencies. PHPUnit had a security vulnerability that needed to be addressed. More recent versions of PHPUnit (v10+) introduced breaking changes that would require a major version bump. Priority of this release was to fix the security vulnerability.
  • Added exclude to deprecated ruleset since WordPressCS v3.3.0. Covered by PHPCompatibilityWP.
  • Renamed tests.

@iobrado iobrado requested a review from a team February 23, 2026 11:11
@iobrado iobrado self-assigned this Feb 23, 2026
Copy link
Copy Markdown
Contributor

@goranalkovic-infinum goranalkovic-infinum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L(e)G(i)T(i)M(no) To je legitimno.

dadadavorin
dadadavorin previously approved these changes Feb 23, 2026
Copy link
Copy Markdown
Contributor

@piqusy piqusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏🏼

Left a question, and I have a concern with this PR about coding standards not passing linter tests (coding standards 🙈 😄 )

CHANGELOG.md Outdated
Comment on lines +190 to +191
regard
of the naming scheme.
of the naming scheme.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is broken in to multiple lines?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For style ✨ joking aside, no idea why was it broken like that, but I'll fix it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Claude (or any other AI tool), they have the tendency to limit line length when writing comments...

"wp-coding-standards/wpcs": "dev-hotifx/escape-output-sniff",
"slevomat/coding-standard": "^8.13.0"
"phpcompatibility/phpcompatibility-wp": "^2.1.8",
"wp-coding-standards/wpcs": "3.3.0",
Copy link
Copy Markdown
Contributor

@dingo-d dingo-d Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will literally break EightshiftCS 🙈

WPCS still hasn't worked on the issue this branch fixed, there were talk about taking this up, but I reckon this will happen somewhere in the middle or at the end of the year hopefully...

Copy link
Copy Markdown
Contributor Author

@iobrado iobrado Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that complicates stuff. We have a high vulnerability in repo, so while at it, I (cough Claude) tried to update some other dependencies as well. Then I guess the only option here is to just update PHPUnit to minimum version that fixes the vulnerability and leave the rest for later.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are worried about this: GHSA-vvj3-c3rp-c85p it's only happening when code coverage for PHPT files is being parsed. This repo isn't using phpt files (it's used for testing PHP internally usually), so I'm not sure this repo is at risk 🤷🏼‍♂️

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the one, yeah. Good to know, but I'd still prefer to fix it, so that Dependabot doesn't scream at us 😂

I already opened a PR that only updates PHPUnit to mentioned version, hopefully that one doesn't break CS.

@iobrado iobrado closed this Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants