Conversation
piqusy
left a comment
There was a problem hiding this comment.
Nice work 👏🏼
Left a question, and I have a concern with this PR about coding standards not passing linter tests (coding standards 🙈 😄 )
CHANGELOG.md
Outdated
| regard | ||
| of the naming scheme. | ||
| of the naming scheme. |
There was a problem hiding this comment.
How come this is broken in to multiple lines?
There was a problem hiding this comment.
For style ✨ joking aside, no idea why was it broken like that, but I'll fix it.
There was a problem hiding this comment.
It's Claude (or any other AI tool), they have the tendency to limit line length when writing comments...
df83a2f
| "wp-coding-standards/wpcs": "dev-hotifx/escape-output-sniff", | ||
| "slevomat/coding-standard": "^8.13.0" | ||
| "phpcompatibility/phpcompatibility-wp": "^2.1.8", | ||
| "wp-coding-standards/wpcs": "3.3.0", |
There was a problem hiding this comment.
This will literally break EightshiftCS 🙈
WPCS still hasn't worked on the issue this branch fixed, there were talk about taking this up, but I reckon this will happen somewhere in the middle or at the end of the year hopefully...
There was a problem hiding this comment.
Well, that complicates stuff. We have a high vulnerability in repo, so while at it, I (cough Claude) tried to update some other dependencies as well. Then I guess the only option here is to just update PHPUnit to minimum version that fixes the vulnerability and leave the rest for later.
There was a problem hiding this comment.
If you are worried about this: GHSA-vvj3-c3rp-c85p it's only happening when code coverage for PHPT files is being parsed. This repo isn't using phpt files (it's used for testing PHP internally usually), so I'm not sure this repo is at risk 🤷🏼♂️
There was a problem hiding this comment.
That's the one, yeah. Good to know, but I'd still prefer to fix it, so that Dependabot doesn't scream at us 😂
I already opened a PR that only updates PHPUnit to mentioned version, hopefully that one doesn't break CS.
Description
Changed