Merged
Conversation
Disallow alternative control structure syntax
iruzevic
previously approved these changes
Apr 8, 2026
dadadavorin
previously approved these changes
Apr 8, 2026
Update PHP_CodeSniffer repository link and schema URL
goranalkovic-infinum
previously approved these changes
Apr 8, 2026
Contributor
|
🥲 You can just use existing sniffs 🙈 |
…niversal.ControlStructures.DisallowAlternativeSyntax - Remove custom DisallowAlternativeSyntaxSniff and its unit tests and docs - Enable Universal.ControlStructures.DisallowAlternativeSyntax from PHPCSExtra (already a transitive dependency via WPCS, no new composer requirement) - Set allowWithInlineHTML=false for strict enforcement matching previous behavior - PHPCSExtra sniff adds auto-fixer, metrics, per-structure error codes, and docs
Contributor
Author
|
Good call, @dingo-d — replaced the custom sniff with Set The custom sniff, its unit tests, and its docs XML have all been removed. |
goranalkovic-infinum
approved these changes
Apr 8, 2026
iobrado
approved these changes
Apr 8, 2026
iruzevic
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Eightshift.ControlStructures.DisallowAlternativeSyntaxsniff that errors onendif,endforeach,endfor,endwhile, andendswitch— enforcing curly braces for all control structuresphpunit.xml.distto point toAllSniffs.phpas the test suite entry point (fixes pre-existingUndefined global variable $PHP_CODESNIFFER_STANDARD_DIRSerror affecting all tests)