Skip to content

test: isolate "evil" file system tests#369

Open
crepererum wants to merge 1 commit intomainfrom
crepererum/vfs-test-isolation
Open

test: isolate "evil" file system tests#369
crepererum wants to merge 1 commit intomainfrom
crepererum/vfs-test-isolation

Conversation

@crepererum
Copy link
Collaborator

With the introduction of write support for the guest VFS (see #133), the individual FS operations are no longer side-effect free. Hence we need to run each test sub-case on a fresh VFS. This is now implemented by getting an actual new UDF state for every case.

With the introduction of write support for the guest VFS (see #133), the
individual FS operations are no longer side-effect free. Hence we need
to run each test sub-case on a fresh VFS. This is now implemented by
getting an actual new UDF state for every case.
| /boot | OK: created |
| /dev | OK: created |
| /etc | OK: created |
| /etc/group | OK: created |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One can see that we already messed this up in a few cases and it would only get worse with #363.

Copy link
Contributor

@Sl1mb0 Sl1mb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants