refactor: extend scalar-udfs WIT interface#50
Merged
crepererum merged 1 commit intomainfrom Sep 2, 2025
Merged
Conversation
jdockerty
approved these changes
Sep 2, 2025
itsjunetime
approved these changes
Sep 2, 2025
host/src/lib.rs
Outdated
| "call scalar_udfs() method", | ||
| Some(&store.data().stderr.contents()), | ||
| )?; | ||
| )??; |
Contributor
There was a problem hiding this comment.
I always get a bit concerned when I see 2+ ? at the end of a statement, so if this error chain is something we can control and improve the return type of, I would say to do so, but otherwise I'm fine with it and understand there may not be anything we can do.
Collaborator
Author
There was a problem hiding this comment.
fair point. I've extended the error handling here a bit to differentiate between the two cases. I think long-term we probably wanna polish the error message a bit further during #26 .
- make it fallible - pass some opaque string into the guest Both are required to properly pass Python source code from the host into the guest.
crepererum
force-pushed
the
crepererum/scalar_udfs_wit_ext
branch
from
8c28545 to
3b1d791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are required to properly pass Python source code from the host into the guest.
Split from #49, where this interface will actually be used.